Only show those tags that correspond with filtered posts. #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofide
reviewed
Aug 29, 2023
galloramiro
reviewed
Aug 29, 2023
| @@ -17,3 +17,5 @@ | |||
|
|
|||
| # BASE_URL to use in any notification that might require them | |||
| BASE_URL = os.environ.get('BASE_URL', 'http://localhost:8000') | |||
|
|
|||
| DISCOURSE_HOST = "testdiscourse.com" | |||
There was a problem hiding this comment.
esto no parece ser referenciado en ninguna otra parte del código, puede ser?
There was a problem hiding this comment.
Sí, en joboffers/publishers/discourse/__init__.py
galloramiro
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this I stopped using
tags(populated by the library) and started to useusefultags, populated in the view considering only those active offers (if the "active" checkbox is selected), or re-usingtagsif the user actually wants to see all the offers.While doing this I noticed that the "active" boolness was inverted everywhere, fixed that.
Also included
DISCOURSE_HOSTin the development settings (a test was failing).